Add random queries to logsdb data generation tests #132109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.2.0
needs:triage
parkertimmins
commented
Jul 29, 2025
test/framework/src/main/java/org/elasticsearch/datageneration/queries/QueryGenerator.java
Outdated
Show resolved
Hide resolved
parkertimmins
commented
Jul 29, 2025
...tTest/java/org/elasticsearch/xpack/logsdb/qa/StandardVersusLogsIndexModeChallengeRestIT.java
Outdated
Show resolved
Hide resolved
parkertimmins
added
>non-issue
:StorageEngine/Mapping
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Wildcard term query currently has an assertion which fails if query contains a unicode character with surrogates. Despite the assertion, the query itself appears to work when assertions are disabled. Remove termQueries for now until this is fixed.
|
Found this unrelated bug while working on these tests: #132144 . Huzzah for randomized testing!!! Because of this I removed term queries for wildcard field, since they throw an assertion error. |
2 tasks
martijnvg
approved these changes
Jul 30, 2025
...tTest/java/org/elasticsearch/xpack/logsdb/qa/StandardVersusLogsIndexModeChallengeRestIT.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/datageneration/queries/QueryGenerator.java
Outdated
Show resolved
Hide resolved
lkts
approved these changes
Jul 30, 2025
test/framework/src/main/java/org/elasticsearch/datageneration/queries/QueryGenerator.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/datageneration/queries/QueryGenerator.java
Show resolved
Hide resolved
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Aug 15, 2025
* upstream/main: (822 commits) Improve Semantic Text Exists Query Tests (elastic#132283) Make hierarchical k-means over centroids cheaper (elastic#132316) Remove unnecessary listener.delegateFailure in IndexShard#ensureMutable (elastic#132294) Add missing release note (elastic#132319) Unmute elastic#131803 (elastic#132295) Include bytes for live docs in ShardFieldStats (elastic#132232) Fix default missing index sort value of data_nanos pre 7.14 (elastic#132162) [DiskBBQ] Quantize centroids using 7 bits instead of 4 bits (elastic#132261) Use panamized version for windows in Int7VectorScorer (elastic#132311) Mute org.elasticsearch.xpack.ml.integration.AutodetectMemoryLimitIT testTooManyByAndOverFields elastic#132310 Mute org.elasticsearch.xpack.ml.integration.AutodetectMemoryLimitIT testManyDistinctOverFields elastic#132308 Update 8.17 version to 8.17.10 (elastic#132303) Mute org.elasticsearch.datastreams.DataStreamsClientYamlTestSuiteIT test {p0=data_stream/10_basic/Create hidden data stream with match all template} elastic#132298 Add random queries to logsdb data generation tests (elastic#132109) ES|QL Inference runner refactoring (elastic#131986) Add basic example to linear-retriever.md (elastic#132196) Refactor RemoteClusterService to be multi-project aware (elastic#131894) ESQL: Mark csv-spec tests (elastic#132098) Mute org.elasticsearch.common.logging.JULBridgeTests testThrowable elastic#132280 Bump versions after 8.19.0 release ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logsdb vs standard tests do queries on fields with known static values. Add a test that queries fields using the randomly generated documents. Currently, only make queries for keyword, text, and wildcard fields. Multiple queries can be provided per value, and each query must return at least one document.